Changeset 216:5f6de1d4618c for imapclient

Timestamp:

15/04/11 12:49:34 (13 months ago)

Author:

Menno Smits <menno@…>

Branch:

default

Message:

getacl() was still using Lexer instead of TokenSource? (fixes #85)

Also added getacl() unit test.

Location:

imapclient

Files:

• imapclient.py (modified) (1 diff)
• test/test_IMAPClient.py (modified) (1 diff)

imapclient/imapclient.py

@@ -657 +657 @@
         self._checkok('getacl', typ, data)
 
-        parts = list(response_lexer.Lexer([data[0]]))
+        parts = list(response_lexer.TokenSource(data))
         parts = parts[1:]       # First item is folder name
-
-        out = []
-        for i in xrange(0, len(parts), 2):
-            out.append((parts[i], parts[i+1]))
-        return out
+        return [(parts[i], parts[i+1]) for i in xrange(0, len(parts), 2)]
 
 

imapclient/test/test_IMAPClient.py

@@ -157 +157 @@
 
 
+class TestAclMethods(IMAPClientTest):
+
+    def test_getacl(self):
+        self.client._imap.getacl.return_value = ('OK', ['INBOX Fred rwipslda Sally rwip'])
+        acl = self.client.getacl('INBOX')
+        self.assertSequenceEqual(acl, [('Fred', 'rwipslda'), ('Sally', 'rwip')])
+
 
 if __name__ == '__main__':